maccoylton / esp-homekit-rgbw-strip

A homekit firmware for a magic home RGBW controller
Apache License 2.0
15 stars 3 forks source link

white color issue #10

Closed toshibochan closed 4 years ago

toshibochan commented 4 years ago

I think is bug but when turn on white all RGBW come ON and become cold white instead the only W come ON

toshibochan commented 4 years ago

my led strip is RGBW is warm white. whit this code (https://github.com/PA7T/magic_home_strip_rgbw) when turn on white only W come on and RGB is off.

maccoylton commented 4 years ago

Ok . .this is a design consideration, not a bug .. my need was white equals all LEDs come on ie RGB & W. This primarily to maximize brightness. You can use the temperature option int he Home app to adjust the warmth. If that does not meet your need the a different implementation would be required,

toshibochan commented 4 years ago

I use the temperature but not get good warm color, still little cold. I wonder if you can add opinion to make only W come on when select white.

maccoylton commented 4 years ago

I;d recommend creating a separate accessory for that since it is different logic

toshibochan commented 4 years ago

where in the code I have to change?

maccoylton commented 4 years ago

where in the code I have to change?

@toshibochan you would need to decide if you wanted a spectate accessory to show up to control the white leds or what would be the logic of transitioning from colour to white, which would be a complete rewrite of the routine that converts the hsi to rgbw and set the new colour. This is not trivial.

Sent with GitHawk

toshibochan commented 4 years ago

I want turn on white and the RGB turn off.

https://github.com/PA7T/magic_home_strip_rgbw This link do that but light is not stable and i can see light flicking all the time. I compare PA7T code and yours but I don’t know where to change for control white color.

vniehues commented 4 years ago

Did you resolve this issue? @maccoylton @toshibochan

toshibochan commented 4 years ago

@vniehues latest firmware is working great. You can chose if you have RGB or RGBW using eve app.

vniehues commented 4 years ago

@toshibochan got it, thank you very much!