macdonst / SpeechRecognitionPlugin

W3C Web Speech API - Speech Recognition plugin for PhoneGap
MIT License
189 stars 95 forks source link

Improve spec compliance, Android interim results, iOS fix for simultaneous speech synthesis. #114

Open wifisher opened 6 years ago

wifisher commented 6 years ago

Description

Related Issues

Motivation and Context

Improves ability to use the same application code for Android, and iOS apps as well as for Chrome.

How Has This Been Tested?

Works in my test app for Android and iOS. The same app code also works in Chrome.

Types of changes

Checklist:

jcesarmobile commented 6 years ago

Wow, awesome work, but please, keep Pull Requests simple, it's preferable that you send 5-6 separate PRs, (one per feature/bug), so it's easier to review and merge.

wifisher commented 6 years ago

I fixed what I needed locally and then decided that I should give it back to the community and pushed up my local changes.

I don't spend much time on Github and it would only let me submit a PR from the head of my master branch. I don't have time to break it out into individual branches so I figured that one bigger PR is better than not doing it at all.

Assuming that you have visibility into the individual commits, they are smaller and fairly self contained. It is likely to be easier to review each commit separately than to review the combined changes for the PR.