search

macearl / Wallhaven-Downloader

A simple download Script for Wallhaven.cc
126 stars 26 forks source link

syntax error: operand expected while downloading favorites #17

Closed soullivaneuh closed 7 years ago

soullivaneuh commented 7 years ago 
$ ./wallhaven.sh -l wallhaven -t favorites
./wallhaven.sh: line 401: ((: 
            count< 48 && count< : syntax error: operand expected (error token is "< ")
macearl commented 7 years ago

The favorite download function is kind of a work in progress.

For now it can only download the Collection named "Default" and nothing else. (see the note in the code)

It is working for me, so if you have a Default collection and are still not able to download them provide me with more data.

soullivaneuh commented 7 years ago

Thank for the quick reply @macearl!

Here is my favorites page:

image

The collection is correctly named default. But it's a private collection, maybe this is why it's failing?

soullivaneuh commented 7 years ago

I made it public but this change nothing, I got the same error.

What additional data could I provide?

soullivaneuh commented 7 years ago

Okay I found why: My password contains some special chars and your script seems to not like it.

I simplify it to make it working.

Some escaping is needed I guess.

macearl commented 7 years ago

Glad you found the cause of this, i'll take a look at the login again and try to escape the special characters.

Just pushed some changes, feel free to try again with your old password