Favourites not removed

[alexreg]

Sometimes when I unmount a remote SSH connection, I am left with the link in the Favourites menu in Finder. In fact when I remount this connection, I have two links and there and have to manually remove one of them.

I would request the following two things, if possible:

1) This bug be fixed so that under the situation of any unmount (or error with the connection/filesystem), the favourite item becomes removed from Finder.

2) The MacFusion app should provide an option (toggle) whether to even add links to the Favourites menu in the first place.

In any case, many thanks for your great work getting MacFusion to function on OS X 10.8!

[ElDeveloper]

Sometimes when I unmount a remote SSH connection, I am left with the link in the Favourites menu in Finder. In fact when I remount this connection, I have two links and there and have to manually remove one of them.

I haven't been able to find a solution for this particular issue.

1) This bug be fixed so that under the situation of any unmount (or error with the connection/filesystem), the favourite item becomes removed from Finder.

It is to my understanding that when an error occurs during mounting, or unmounting the item is removed. I'll investigate upon this.

2) The MacFusion app should provide an option (toggle) whether to even add links to the Favourites menu in the first place.

Seems like a reasonable idea, I initially wanted this to be the default behavior as it comes handy whenever needed, or at least it does for me. The toggle sounds like a good idea.

[alexreg]

Thanks for the reply, Yoshiki.

Regarding 1), I've also actually noticed that when a mount fails (in certain cases), the 'Mount' button changes to 'Unmount' even though the drive has not actually been mounted. From there onwards the text of the button and whether it is enabled, are out of sync with the current state of the drive.

Are you any closer to figuring out why drives randomly get disconnected in the background after a certain time, by the way? (The issue reported by another on this thread too, it seems.)

Appreciate your work on all this!

Alex

On 9 Dec 2012, at 00:04, Yoshiki notifications@github.com wrote:

Sometimes when I unmount a remote SSH connection, I am left with the link in the Favourites menu in Finder. In fact when I remount this connection, I have two links and there and have to manually remove one of them.

I haven't been able to find a solution for this particular issue.

1) This bug be fixed so that under the situation of any unmount (or error with the connection/filesystem), the favourite item becomes removed from Finder.

It is to my understanding that when an error occurs during mounting, or unmounting the item is removed. I'll investigate upon this.

2) The MacFusion app should provide an option (toggle) whether to even add links to the Favourites menu in the first place.

Seems like a reasonable idea, I initially wanted this to be the default behavior as it comes handy whenever needed, or at least it does for me. The toggle sounds like a good idea.

— Reply to this email directly or view it on GitHub.

[ElDeveloper]

Regarding 1), I've also actually noticed that when a mount fails (in certain cases), the 'Mount' button changes to 'Unmount' even though the drive has not actually been mounted. From there onwards the text of the button and whether it is enabled, are out of sync with the current state of the drive.

I've also notice this, if you could open an issue regarding this, that would be great.

Are you any closer to figuring out why drives randomly get disconnected in the background after a certain time, by the way? (The issue reported by another on this thread too, it seems.)

This could be caused by many reasons, given that I haven't found this, I would suggest checking the following things:

• Your internet provider, intermittent internet connections could probably be causing this.
• The server you are connecting to, connection timeouts are reasonably common.
• Maybe OS X Fuse, but I don't think so, still could be try connecting via terminal.

[alexreg]

Sure, I'll try to open an issue for this shortly when I get a little time (I'm unusually busy at the moment).

I'll keep an eye out on the random disconnection issue, but it's definitely not the Internet provider (I'm on a reliable university LAN connection). It's possible the server doesn't like prolonged activity, but that should show up in the logs, right? So I'll check for that. It would however be very handy if MacFusion could somehow prevent such timeouts by sending a NOOP or equivalent null message to the server every so often.

Thanks, Alex

On 14 Dec 2012, at 07:56, Yoshiki notifications@github.com wrote:

Regarding 1), I've also actually noticed that when a mount fails (in certain cases), the 'Mount' button changes to 'Unmount' even though the drive has not actually been mounted. From there onwards the text of the button and whether it is enabled, are out of sync with the current state of the drive.

I've also notice this, if you could open an issue regarding this, that would be great.

Are you any closer to figuring out why drives randomly get disconnected in the background after a certain time, by the way? (The issue reported by another on this thread too, it seems.)

This could be caused by many reasons, given that I haven't found this, I would suggest checking the following things:

Your internet provider, intermittent internet connections could probably be causing this. The server you are connecting to, connection timeouts are reasonably common. Maybe OS X Fuse, but I don't think so, still could be try connecting via terminal. — Reply to this email directly or view it on GitHub.

[alexreg]

Hi Yoshiki,

An update from my side: It seems that the drives are not being arbitrarily connected at least, which is good news. A sleep and subsequent wake however causes them to disconnect. It would be great to have an option that automatically reconnects to all drives on wake, that were formerly connected before the sleep occurred. What do you think of this?

Along with the other suggested fixes/improvements, I think we'd then have a perfect utility at our hands!

Cheers, Alex

On 14 Dec 2012, at 07:56, Yoshiki notifications@github.com wrote:

Regarding 1), I've also actually noticed that when a mount fails (in certain cases), the 'Mount' button changes to 'Unmount' even though the drive has not actually been mounted. From there onwards the text of the button and whether it is enabled, are out of sync with the current state of the drive.

I've also notice this, if you could open an issue regarding this, that would be great.

Are you any closer to figuring out why drives randomly get disconnected in the background after a certain time, by the way? (The issue reported by another on this thread too, it seems.)

This could be caused by many reasons, given that I haven't found this, I would suggest checking the following things:

Your internet provider, intermittent internet connections could probably be causing this. The server you are connecting to, connection timeouts are reasonably common. Maybe OS X Fuse, but I don't think so, still could be try connecting via terminal. — Reply to this email directly or view it on GitHub.

[ElDeveloper]

As an update regarding this issue, I have added a checkbox to select which filesystems you want added to Finder's sidebar ( 20d7ffe62e27825c90d6b7572f16f4c2962da4f5 ), though I haven't been able to find a way to make a favorite not being removed from Finder's sidebar (the other issue you encountered). If you can provide me with step by step instructions on how to do this, I will make sure to investigate what is causing the problem and hopefully fix it.

---

Sure, I'll try to open an issue for this shortly when I get a little time (I'm unusually busy at the moment).

Awesome, it is always useful to have granularity among the problems to be solved.

An update from my side: It seems that the drives are not being arbitrarily connected at least, which is good news. A sleep and subsequent wake however causes them to disconnect. It would be great to have an option that automatically reconnects to all drives on wake, that were formerly connected before the sleep occurred. What do you think of this?

Glad to hear that it's now working for you. The enhancement you mention, would be (I think) something that is encompassed by FUSE or rather OSX FUSE, there are I think a couple topics discussing something similar to this.

[alexreg]

Hi Yoshiki,

On 28 Dec 2012, at 03:34, Yoshiki notifications@github.com wrote:

As an update regarding this issue, I have added the checkbox to select which filesystems you want added to Finder's sidebar, though I haven't been able to find a way to make a favorite not being removed from Finder's sidebar. If you can provide me with step by step instructions on how to do this, I will make sure to investigate what is causing the problem and hopefully fix it.

That's great; thanks for that. As a matter of fact I haven't seen this issue occur lately, so fingers crossed some other update fixed it somehow. if it occurs again, I will try to record the steps for reproduction so you can take a look. As an extra (rather tiny) point, perhaps you could make it possible to change the order in which drives are inserted into the Favourites sidebar (relative to each other). That would be a nice UX perk.

Sure, I'll try to open an issue for this shortly when I get a little time (I'm unusually busy at the moment).

Awesome, it is always useful to have granularity among the problems to be solved.

Done. I've opened an issue for another minor thing too. An update from my side: It seems that the drives are not being arbitrarily connected at least, which is good news. A sleep and subsequent wake however causes them to disconnect. It would be great to have an option that automatically reconnects to all drives on wake, that were formerly connected before the sleep occurred. What do you think of this?

Glad to hear that it's now working for you. The enhancement you mention, would be (I think) something that is encompassed by FUSE or rather OSX FUSE, there are I think a couple topics discussing something similar to this.

Okay, thanks for the pointers. I'll take a look!

[alexreg]

So you should be able to reproduce the issue where the links to the MacFusion drives are left in the Favorites sidebar of Finder (even when the drives have been unmounted and are reporting themselves correctly as such), as follows:

Connect to one or more SSH drives using MacFusion. Verify that the drives appear in the Favorites section of the sidebar in Finder. Put the computer to sleep. Wake it up after a short while. Observe that the MacFusion window correctly displays the drives as unmounted. Observe that the links to the drives still (incorrectly) show up in the Favorites menu of Finder.

So it seems that the unmounting is at least being detected correctly somewhere in the app (?), hence the correct status on the main window. But clearly the items in the Favourites menu are not being removed automatically when they should be.

Cheers, A

On 28 Dec 2012, at 03:34, Yoshiki notifications@github.com wrote:

As an update regarding this issue, I have added the checkbox to select which filesystems you want added to Finder's sidebar, though I haven't been able to find a way to make a favorite not being removed from Finder's sidebar. If you can provide me with step by step instructions on how to do this, I will make sure to investigate what is causing the problem and hopefully fix it.

Sure, I'll try to open an issue for this shortly when I get a little time (I'm unusually busy at the moment).

Awesome, it is always useful to have granularity among the problems to be solved.

An update from my side: It seems that the drives are not being arbitrarily connected at least, which is good news. A sleep and subsequent wake however causes them to disconnect. It would be great to have an option that automatically reconnects to all drives on wake, that were formerly connected before the sleep occurred. What do you think of this?

Glad to hear that it's now working for you. The enhancement you mention, would be (I think) something that is encompassed by FUSE or rather OSX FUSE, there are I think a couple topics discussing something similar to this.

— Reply to this email directly or view it on GitHub.

[alexreg]

Incidentally, the sleep issue seems to be entirely unrelated to the login window issue that you linked me to. In fact, displaying the login window then going back to the MacFusion drives, they remain connected and working fine.

Still, you may be right in that OSXFUSE should handle the reconnection to the drives upon wake from sleep... perhaps, I just don't know!

Cheers, A

On 28 Dec 2012, at 03:34, Yoshiki notifications@github.com wrote:

As an update regarding this issue, I have added the checkbox to select which filesystems you want added to Finder's sidebar, though I haven't been able to find a way to make a favorite not being removed from Finder's sidebar. If you can provide me with step by step instructions on how to do this, I will make sure to investigate what is causing the problem and hopefully fix it.

Sure, I'll try to open an issue for this shortly when I get a little time (I'm unusually busy at the moment).

Awesome, it is always useful to have granularity among the problems to be solved.

An update from my side: It seems that the drives are not being arbitrarily connected at least, which is good news. A sleep and subsequent wake however causes them to disconnect. It would be great to have an option that automatically reconnects to all drives on wake, that were formerly connected before the sleep occurred. What do you think of this?

Glad to hear that it's now working for you. The enhancement you mention, would be (I think) something that is encompassed by FUSE or rather OSX FUSE, there are I think a couple topics discussing something similar to this.

— Reply to this email directly or view it on GitHub.

[ElDeveloper]

That was really useful, thank you very much. I think I've fixed it in the latest build which should be available for download now. Let me know how it goes for you.

[alexreg]

Hrmm; it seems that the latest build doesn't add items to the Favorites menu by default, as per your update, but I can't find the option anywhere for adding them like before. Also, it seems I can't add these Favorites links manually in Finder (by dragging into the sidebar) -- this only happens for MacFusion drives; other drives don't have this issue it seems.

A

On 29 Dec 2012, at 22:19, Yoshiki notifications@github.com wrote:

That was really useful, thank you very much. I think I've fixed it in the latest build which should be available for download now. Let me know how it goes for you.

— Reply to this email directly or view it on GitHub.

[ElDeveloper]

Yes, that is the default behavior now, seems like something reasonable IMHO, as this has been the original behavior of Macfusion. The option is under the Macfusion tab in the settings for each filesystem (see screen capture). The second issue you report is an odd one that I'm able to reproduce, not sure what's going on there.

[alexreg]

Aha, I see that for myself now. Thanks. When I originally mentioned it, I was thinking more of a global option that enabled/disable it, but this work well too. Perhaps both would be ideal, though I shan't harry you to implement that!

Indeed, the issue with not being able to manually add the links in Favourites is peculiar. I believe (although my memory may fail me) that it was possible in a previous version -- perhaps before you made the various updates -- so perhaps it would be worth checking.

Let me know if you need any more testing or feedback.

Cheers, A

On 31 Dec 2012, at 06:46, Yoshiki notifications@github.com wrote:

Yes, that is the default behavior now, seems like something reasonable IMHO, as this has been the original behavior of Macfusion. The option is under the Macfusion tab in the settings for each filesystem (see screen capture). The second issue you report is an odd one that I'm able to reproduce, not sure what's going on there.

— Reply to this email directly or view it on GitHub.

[ElDeveloper]

Great, let me know if the issue happens again and as previously mentioned, providing a step by step guide is very helpful to track the bugs down.

[ElDeveloper]

Also for some reason GitHub only showed me the first part of your post. Didn't see the other part. So to make it clear, in my previous post I was asking about the specific issue of filesystems not being removed from Finder's sidebar so if you think this has been solved, let me know so I can close this issue or of course you can close it.

Regarding dragging to the sidebar, I'll try and test that with a previous build and see what happens, though this doesn't sound to me like a major issue. :fire_engine: haha.

[alexreg]

Oh, but I thought you said you could reproduce this bug? You're talking about the one where one manually drags the drive into the Favorites menu in Finder, right?

On 31 Dec 2012, at 07:13, Yoshiki notifications@github.com wrote:

Great, let me know if the issue happens again and as previously mentioned, providing a step by step guide is very helpful to track the bugs down.

— Reply to this email directly or view it on GitHub.

[alexreg]

Hi Yoshiki. Ah right, well that's clearer now. Thanks. Dragging to the sidebar... yes, not a big issue. Maybe worth 5 or 10 minutes checking into it, and if the solution seems relatively simple, try it, otherwise don't bother?

Cheers

On 31 Dec 2012, at 07:39, Yoshiki notifications@github.com wrote:

Also for some reason GitHub only showed me the first part of your post. Didn't see the other part. So to make it clear, in my previous post I was asking about the specific issue of filesystems not being removed from Finder's sidebar so if you think this has been solved, let me know so I can close this issue or of course you can close it.

Regarding dragging to the sidebar, I'll try and test that with a previous build and see what happens, though this doesn't sound to me like a major issue. haha.

— Reply to this email directly or view it on GitHub.

[ElDeveloper]

The "dragging to the sidebar" problem seems to be related to an intrinsic limitation of SSHFS and perhaps of FUSE. I tested by mounting a FS manually i. e. calling the sshfs command from the terminal. This in turns made me realize of how useful the new option to add to Finder's sidebar option might be given.

Also, given that I haven't seen the original issue reported in this thread nor I have experienced it lately, I'm closing this issue.

[alexreg]

That sounds fair enough. Perhaps an option for here to add the favourites items (start or end of list), and in a specified order might be useful. Also perhaps the global on/off option for adding favourites items or not. :-)

But thanks for checking into this, in any case!

On 20 Jan 2013, at 02:28, Yoshiki notifications@github.com wrote:

The "dragging to the sidebar" problem seems to be related to an intrinsic limitation of SSHFS and perhaps of FUSE. I tested by mounting a FS manually i. e. calling the sshfs command from the terminal. This in turns made me realize of how useful the new option to add to Finder's sidebar option might be given.

Also, given that I haven't seen the original issue reported in this thread nor I have experienced it lately, I'm closing this issue.

— Reply to this email directly or view it on GitHub.