search

macfusion-ng / macfusion2

Macfusion2
225 stars 28 forks source link

Change default mounting path #22

Open ElDeveloper opened 8 years ago

ElDeveloper commented 8 years ago

See #20.

ElDeveloper commented 8 years ago

@tessus and @jcrbloch (and really everyone else) let me know if this looks good to you guys.

mischievous commented 7 years ago

The version of fuse 3.5.x will create the mount points for you automagically. No need to create them in MacFusion if the user is running fuse 3.5.x. But the filesystems need to recognize this fact now too. I have a fix for the SSHFS. Could an option be added to have MacFusion create the directory or not? Or even better detect that the code is running on Sierra or later and then auto set the option to create the mount point or not.

166MMX commented 7 years ago

@mischievous Oh that is great news :) Such conditions could be implemented. Would you mind sharing your SSHFS fix with us? I know that we can get the osxfuse version number. Not sure if we also can get the version of sshfs but that should be neglectable.

tessus commented 7 years ago

@166MMX please send me an email. There are a few sshfs / fuse issues I'd like to explain, but I couldn't find your email.

mischievous commented 7 years ago

@166MMX when you say share... You mean create a branch of the osxfuse/sshfs and check in my changes to it? I can do that.

mischievous commented 7 years ago

I think I did it. https://github.com/mischievous/sshfs

ElDeveloper commented 7 years ago

But the filesystems need to recognize this fact now too. I have a fix for the SSHFS.

@tessus Would this need to make its way to upstream, or do you think we can just keep this fork as a submodule of the project and compile that? You are more familiar with the problems/internals of sshfs.

Such conditions could be implemented. Would you mind sharing your SSHFS fix with us?

@166MMX I agree, this doesn't sound too complicated, if I am understanding correctly, we would just need to change the MFServerFS setupMountPoint method to deal with this logic.

Could an option be added to have MacFusion create the directory or not? Or even better detect that the code is running on Sierra or later and then auto set the option to create the mount point or not.

Yes, I think this sounds like a great idea. This should be easy to do. The one thing this PR is fixing though is the fact that we no longer can write to /Volumes/ (to quote @mischievous - Bloody apple!).