macgile / DataGridFilter

WPF Filterable Datagrid, multi language
MIT License
372 stars 77 forks source link

Transparent window makes popup transparent #124

Closed MichaelInkster closed 11 months ago

MichaelInkster commented 1 year ago

If the parent window is transparent, the popup window becomes transparent. Can the background be changed to inherit from the FilterDataGrid rather than the Window?

KC-MarKamp commented 11 months ago

Hi @MichaelInkster, I'm currently working on it! I'm making a property for it so you can set the color yourself from within the control🙂.

Edit: See my pull request (https://github.com/macgile/DataGridFilter/pull/130#issue-1926903475)

macgile commented 11 months ago

Hi,

I merged your contribution

best regards

KC-MarKamp commented 11 months ago

Hi @macgile, thanks! Happy to help! Perhaps the other issue regarding to the background, Issue #122, can also be closed with this PR :)

macgile commented 11 months ago

Hi, Changing the background color was already a user request. I cannot accommodate all requests for design changes. I also want to keep the configuration by DependencyProperty as simple as possible, they should not multiply