macgitver / MacGitverModules

DEPRECATED: Modules for MacGitver
5 stars 1 forks source link

Rewrite history detail view #56

Closed scunz closed 11 years ago

scunz commented 11 years ago

This change is a total rewrite of the current history view.

Instead of drawing it all ourselves, setup some HTML and show that in a browser. This addresses most of the details related topics in macgitver/MacGitver#3:

Snapshot from a Linux and Qt4 based build: History_Details

scunz commented 11 years ago

@antis81, could you please review this and merge it, if it's okay?

This also simplifies conversion of HistoryView to a ContextView.

scunz commented 11 years ago

Out of those 3 options, none is anything like appealing to me:

The font for the header (commit short message) is a little too big. 1 or 2pt smaller and it would go great.

It is relative to the application wide font, actually. I tried with font-size: large; but that didn't result in any difference from omitting it. Maybe we should just go with the default size and make that subject line bold.

Minor: just keep the underline for the header and remove any borders.

I don't really understand that. However, I'm not too closely looking at how it will be looking. I'm currently way more into functionality. So as a bottom line, I'd say: check the code out, prettify the template at the bottom of the .cpp file, commit to the PR and merge it. (I'd also be okay with reversed order :-) )

antis81 commented 11 years ago

As said already, this is highly cosmetic. The code looks very ok to me. So I simply merge it without any changes. Just to get an impression on how it would look like (bold font and no border): sample_hist_details_without_borders

scunz commented 11 years ago

Thanks, so this is in, I can continue with the ViewContextData migration for ModHistory.

Btw, I'm preparing 2 new Modules:

Not sure yet, if they will finally be based on development or uncrappify branches.