macgitver / MacGitverModules

DEPRECATED: Modules for MacGitver
5 stars 1 forks source link

Improvements to repository tree #66

Closed antis81 closed 11 years ago

antis81 commented 11 years ago
antis81 commented 11 years ago

Should we merge here in favor to get the working features in?

Btw.: It would be a nice feature for GH web-interface to create a PR out of an existing issue. Would make it easier to separate topics. Seems, this is currently possible through the API only. Or am I just blind?

Some words on the implementation: The branch info was added in the tooltip role of an item. The decision for that was initially, that the call to branchDisplay returns HTML text, which is not rendered in the tree item and shown as plain text. It would be actually better to perform the HTML formatting somewhere else instead of the RepoInfo item. Anyways, it behaves like intended: Marks an active branch orange, otherwise "detached at ..." is shown. For the submodule info it would be cool, if multiple things are shown (e.g. "git describe --tags"). Further we could add information, showing where it "was before" and where it "is now". But I think keeping it as is is good enough for now.

scunz commented 11 years ago

Btw.: It would be a nice feature for GH web-interface to create a PR out of an existing issue. Would make it easier to separate topics. Seems, this is currently possible through the API only. Or am I just blind?

Absolutely correct. Would be a nice addition. Maybe someone should write a mail to support@github.com. They're actually quite responsive on user feedback.

scunz commented 11 years ago

Well, I'd say lets get this in - and I agree on the fact that RepositoryInfo is not the right place for this HTML formatting.

What would you think about creating a widget that looks like the bubble in this box: at_sacu

We could put some of them into the status bar at the bottom (which currently looks wired with the coloured branch name). And we could also use this with a text like "master +4" in the tree (grey in the usual case and in branch-colour for the active repository)

We'd just need the painting code in a separate method somewhere...

antis81 commented 11 years ago

Looks like a cool addition :+1:.

antis81 commented 11 years ago

Ok, I'll remove the spaces and merge this one afterwards. @scunz Think it goes well with your improvements of our RepoMan.