search

macgitver / MacGitverModules

DEPRECATED: Modules for MacGitver
5 stars 1 forks source link

follow gitwrap ref_stuff branch #82

Closed antis81 closed 10 years ago

antis81 commented 10 years ago

This PR is following the current development in GitWrap and fixes stuff. Should be merged as soon as GitWrap stuff is ready.

scunz commented 10 years ago

Thanks for the Header think. I'm actually not yet compiling MGV against new gitWrap, yet. But when I did (before the header change), there were more than 2 deprecation warnings. Did you intend to catch them all or is this just a random fix?

antis81 commented 10 years ago

Did you intend to catch them all or is this just a random fix?

It is not a random fix. We can use it to follow the new GitWrap features and merge to development. I just wasn't sure, if you're working already on swiping out deprecated warnings. At this place, there's no warning - which I saw to late should have been there. Some warnings need to be fixed in MGVCore.

scunz commented 10 years ago

Fine. I did not pay too much attention to the deprecation warnings (After all, I created these in order to do it not now this time). I was just wondering, because I see roughly 100 warnings - and you're fixing just 2.

antis81 commented 10 years ago

...I see roughly 100 warnings - and you're fixing just 2.

:) - I also see the warnings, but these 2 gave compile errors. Added the deprecated function now locally, I'll add it as another PR to GitWrap, letting you work on :walking:. But you're right, it is better to do the real fix after merging the big RM branch to make it bright and shiny again :star2:.

scunz commented 10 years ago

And this one, too...

antis81 commented 10 years ago

Thanks.