Update the models on object changes

[antis81]

Description

This is the next big step to bring the models in sync' with changes in the Git repository. Those changes can origin from either inside MacGitver or a random application (like i.e. Git CLI).

When a Git repository changes, MacGitver must update its data models to work on the correct data.

For example a new commit, branch, tag, ... was created. MacGtiver has to react and update its data models, which in turn trigger an update on the bound views.

All changes are detected by a central instance - the repository manager MacGitver::repoMan() - which calls signals on a "detected change".

Here is a list of possible events for orientation.

Module "Repository"

• [x] repo opened
• [x] repo closed
• [x] repo activated
• [x] submodule activated
• [x] HEAD of any "opened" repo changed
  • We don't need that!

    Module "History"

• [x] update inline references
  • [x] ref created
  • [x] ref deleted -> see libMacGitverCore PR 22 there
  • [x] ref renamed -> This is not possible, because the reference name is the "lookup key". If it changes, it would generate a "refDeleted" and a "refCreated" event.
  • [x] ref moved (the "reference target" changed)
  • [x] HEAD changed (or any symbolic reference) -> :exclamation: See here
• [x] update commit list -> Needs to be realized in new PR.

  Module "RefsViews"

• [x] ref created
• [x] ref deleted
• ref renamed -> see above in "Module "History""
• [x] ref moved (detects also a changed HEAD)

  Status-View

• [x] ref moved (detects also a changed HEAD)
  • see libMacGitverCore PR 22 there

    Module "Work-Tree / Index"

    WorkTree and Index/Stage View

Updating the work tree and the index has to go in another PR. Currently MGV does not react to changes in the working tree or index.

Migration of the "Reference View"

Please read dicussion in Redmine

The reference view should be migrated to better integrate RM::RepoMan. Changing this now would make this PR unnecessarily complex.

Other changes / improvements

Reference View

• :+1: The reference tree is now expanded in initial state.
• :+1: The reference tree will no more collapse unexpectedly after changes.

  History View

• :+1: Inline References are now sorted alphanumerically by type (fixed priorities) - yeah!
  • If you're interested look here: https://github.com/macgitver/MacGitverModules/commit/7b9d2ced67cf197fbeb5205aafbf2e79ddbe00b1#diff-53684d014451b869081860fdde26e03bR89
• :+1: Fixed recognition of status changes in inline references.
• :+1: The "default" diff behaviour is now "diff to all parents". By default, the diff view shows the changes in the selected commit.
  • Technically, there is no default behaviour. "All parents" is just the first entry in the list. Setting a default behaviour is a candidate for the history settings.
• :+1: Display a detached HEAD

[antis81]

@scunz Would be nice, if you could verify this change bfd7051.

[antis81]

@scunz :+1: Some good news: In the current implementation state, the HistoryModel and ReferenceModel both are aware of "reference creation". Thus, independent of the source (inside/outisde MGV), the views will get updated correctly based on the RepoMan events.

When there's light :bulb:, there's also some shadow: Seems like the RM::EventsInterface needs extensions. Currently I don't get a signal when ...

1. ... HEAD was set (i.e. the active branch changed).
2. ... a reference was removed
3. ... an object was created (i.e. a new commit)

:question: Do we need definitions for them? Or is there something I overlooked here?

[antis81]

I'm somewhat excited of what is available in this PR :+1:. It brings MGV a big step closer to a state, that's "publicly presentable". Well, some heavy weight bugs are still waiting to be fixed (especially memory consumption in the DiffViewer) ... but that's the next big story.

After completing some important things, I'm going to merge soon.

@scunz If you find any time, please help with the "refresh" topic. The most important parts happen in libMacGitverCore. I contribute my local work there as well - you shall see. At least, now we have real consumers for our events.

@BugSniffer If you want to know why I talk confusing stuff sometimes - just look here :smile:.

[antis81]

@scunz That's the way aha, aha - I like it!! :smile:

Event detection for references is mostly complete. Basically nothing is missing. Just some possible optimizations:

• The "source repo" of an event is not checked due to the fact, we don't have that information available yet.
• If we check for the "HEAD" reference in RM::Ref::selfRefresh, we can add a headMoved event. This has the advantage, that the status-view will get less events.
• On quit, the event refAboutToBeDeleted is sent for every reference. Could be blocked here!
• Of course the 15 secs. refresh interval is annoying. But hey, it works!!!!! We need some mechanism though to trigger an "immediate update".

:boat: I'd like to merge soon. As always not everything is implemented.

Other bigger tasks worth a new PR:

• Adding commits to HistoryView on creation
• Migrate / Refresh the WorkingTreeView
• Refresh the IndexView

[antis81]

:+1: Migration of "RefItem" works 90% locally! Some topics to be solved, but nothing too bad ... you'll see.

The new feature branch ngf/migrate-refitem is based on this one - which is unusual, but a sane solution for this situation.

This PR must be merged together with PR 22 in libMacGitverCore -> look here

@scunz I'd like to merge this one. Could you do some last review?

@BugSniffer FYI

[antis81]

@scunz Think we can close this one in favour to #99.