search

macgitver / MacGitver_oldie

DEPRECATED: Platform independent Git user interface.
http://www.macgitver.org
4 stars 0 forks source link

Removal of Submodules #8

Closed scunz closed 11 years ago

scunz commented 11 years ago

@antis81 Can I remove the ModSubmodule code?

antis81 commented 11 years ago

Yeah, feel free to remove. We talked about keeping that some time ago :clock1:. But actually most of the former structure was moved into the repo tree. What's left are some unfinished add/remove dialogs from the beginning, but sure we find better ways to achieve that :smile:.

scunz commented 11 years ago

Add/Remove? Is this code working? Should I move it somewhere?

I could as well just disable the ADD_SUBDIRECTORY call in the parent CMakeLists file. The reasoning behind is that i want to get rid of the old repo-changed code - and modSM is one of the few remaining consumers of that.

antis81 commented 11 years ago

Yes, that's an idea. Without looking into the code I'd say we don't need that anymore. It is currently not used anywhere in MGV where it would make sense. We tried out some nice ideas there though and I'd like to keep them in mind. So removing the entry from CMakeLists.txt is a good deal until we decide how to proceed further.

scunz commented 11 years ago

Also, long done ^^