CREATEVOLUME: Invalid volume size if 143KB is specified

mach-kernel / cadius

A maintained fork of BrutalDeluxe's Cadius ProDOS disk imaging utility (used for making Apple II disk images).

GNU General Public License v3.0

31 stars 9 forks source link

Closed inexorabletash closed 6 years ago

inexorabletash commented 6 years ago

The docs indicate:

The Volume Size may be given in KB or in MB. Any size between 143KB and 32MB is valid (143KB, 800KB, 1600KB, 32MB, ...).

... but specifying 143KB results in:

Error : Invalid volume size : '143KB'.

The check in Main.c reads:

      if(param->new_volume_size_kb <= 143 || param->new_volume_size_kb > 32768)
        param->new_volume_size_kb = 0;

Should that be < 143 ?

mach-kernel commented 6 years ago

It appears so! Nice catch. I'll fix this one up and make a release :oncoming_police_car:

inexorabletash commented 6 years ago

Confirmed, thanks!

mach-kernel commented 6 years ago

@inexorabletash I'll make some binaries after meetings 🚔