search

mach-kernel / cadius

A maintained fork of BrutalDeluxe's Cadius ProDOS disk imaging utility (used for making Apple II disk images).
GNU General Public License v3.0
30 stars 9 forks source link

CREATEVOLUME: Allow 140k images? #28

Closed inexorabletash closed 4 years ago

inexorabletash commented 4 years ago

Follow on to #22 - why is the limit 143KB anyway?

A 5.25" floppy image is 143360 bytes but that'd be 140K the way cadius counts (140KiB).

Should the limit be 140KB instead? This seems to work just fine.

-      if(param->new_volume_size_kb < 143 || param->new_volume_size_kb > 32768)
+      if(param->new_volume_size_kb < 140 || param->new_volume_size_kb > 32768)
mach-kernel commented 4 years ago

I will reach out to Antoine to figure out why this is the case (maybe there's some motivation for it) -- but this makes sense and I don't see any reason to not make this change.

inexorabletash commented 4 years ago

Any word from Antoine on this, while we're doing end-of-the-year hacking?

mach-kernel commented 4 years ago

I sent a Facebook Message last night with a link to this thread 😸, waiting to hear back

inexorabletash commented 4 years ago

FWIW, another fork of cadius has this:

https://github.com/digarok/cadius/commit/e944a1c4a50d4a1ea2567afd522e63d9c600a5d5

mach-kernel commented 4 years ago

@inexorabletash PR is up, will merge by EOD. I never heard back from Antoine.