update component names - Githubissues

machadogj / react-native-carousel-control

React Native Carousel control with support for iOS and Android

MIT License

247 stars 55 forks source link

update component names #40

Open amkayondo opened 4 years ago

amkayondo commented 4 years ago

What the PR does

Change componentWillReceiveProps to UNSAFE_componentWillReceiveProps
Change componentWillMount to UNSAFE_componentWillMount As for the names changes done by react updates https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

dusan-turajlic commented 4 years ago

Wouldn't the more correct way to do this be to actually change the method names and create a new version tag in git for this project? That way it wouldn't need to maintain old UNSAFE_ methods but still have a version that can be used if your project is running an old version of RN

amkayondo commented 4 years ago

am using current react native version, so would you update the names because I love using this package😊

dusan-turajlic commented 4 years ago

I'm not a maintainer of this project I'm actually quite new to react-native. I was just wondering if there was a reason for just adding the UNSAFE_ instead of updating the class to have new methods. My comment was not a suggestion or advice it was just a question because I would like to know.