search

machadogj / react-native-carousel-control

React Native Carousel control with support for iOS and Android
MIT License
247 stars 55 forks source link

componentWillReceiveProps has been marked as 'unsafe' #41

Closed dusan-turajlic closed 4 years ago

dusan-turajlic commented 4 years ago

I keep getting a warning in my app saying 

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Carousel

Any changes you could update the method name and create a new tag for the new version? Also componentWillMount has also been marked as UNSAFE.

dusan-turajlic commented 4 years ago

Never mind saw there was already a PR open for this