machakann / vim-highlightedyank

Make the yanked region apparent!
844 stars 22 forks source link

Exiting visual causes weird side-effect #51

Closed trev-dev closed 1 year ago

trev-dev commented 1 year ago

When I enter, then exit visual mode, the whole buffer highlights briefly.

If I yank something, then enter and exit visual mode, the last thing I yanked highlights again.

I disabled all of my other plugins and could still reproduce it.

machakann commented 1 year ago

Thank you for your report. Can I ask about your environment? (OS, vim version, terminal, ...) When the whole buffer is highlighted, is the buffer text in a register?

trev-dev commented 1 year ago

Here's my :version

:version
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Jan 01 1980 00:00:00)
Included patches: 1-1369
Compiled by nixbld
Huge version with GTK3 GUI.  Features included (+) or not (-):
+acl               +cindent           +cursorshape       +file_in_path      +job               +menu              +mouse_urxvt       +popupwin          +signs             -tag_any_white     +user_commands     +windows
+arabic            +clientserver      +dialog_con_gui    +find_in_path      +jumplist          +mksession         +mouse_xterm       +postscript        +smartindent       -tcl               +vartabs           +writebackup
+autocmd           +clipboard         +diff              +float             +keymap            +modify_fname      +multi_byte        +printer           -sodium            +termguicolors     +vertsplit         +X11
+autochdir         +cmdline_compl     +digraphs          +folding           +lambda            +mouse             +multi_lang        +profile           -sound             +terminal          +vim9script        -xfontset
-autoservername    +cmdline_hist      +dnd               -footer            +langmap           +mouseshape        -mzscheme          -python            +spell             +terminfo          +viminfo           +xim
+balloon_eval      +cmdline_info      -ebcdic            +fork()            +libcall           +mouse_dec         +netbeans_intg     +python3           +startuptime       +termresponse      +virtualedit       +xpm
+balloon_eval_term +comments          +emacs_tags        +gettext           +linebreak         -mouse_gpm         +num64             +quickfix          +statusline        +textobjects       +visual            -xsmp
+browse            +conceal           +eval              -hangul_input      +lispindent        -mouse_jsbterm     +packages          +reltime           -sun_workshop      +textprop          +visualextra       +xterm_clipboard
++builtin_terms    +cryptv            +ex_extra          +iconv             +listcmds          +mouse_netterm     +path_extra        +rightleft         +syntax            +timers            +vreplace          -xterm_save
+byte_offset       +cscope            +extra_search      +insert_expand     +localmap          +mouse_sgr         -perl              +ruby              +tag_binary        +title             +wildignore
+channel           +cursorbind        -farsi             +ipv6              +lua               -mouse_sysmouse    +persistent_undo   +scrollbind        -tag_old_static    +toolbar           +wildmenu
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/nix/store/f4z104msr4ax2lb4s04vcl9zj67s5chh-vim-full-9.0.1369/share/vim"
Compilation: see nix-store --read-log /nix/store/f4z104msr4ax2lb4s04vcl9zj67s5chh-vim-full-9.0.1369
Linking: see nix-store --read-log /nix/store/f4z104msr4ax2lb4s04vcl9zj67s5chh-vim-full-9.0.1369

Reproduced both on nix via WSL2 and NIxOS

The highlighting on exit visual does not impact my registers. Yanking and highlighting does, as intended.

machakann commented 1 year ago

I finally found the reason. Probably, you are using `'go-a' or auto-select. Vim-highlightedyank did not work well with the auto-select feature.

Please reopen freely if you still find problems.

trev-dev commented 1 year ago

@machakann Yep, that was it. I had not set my clipboard option and it comes with autoselect by default