machawk1 / wail

:whale2: Web Archiving Integration Layer: One-Click User Instigated Preservation

https://matkelly.com/wail

MIT License

346 stars 33 forks source link

Test functionality in Python 3.8 #443

Open machawk1 opened 4 years ago

machawk1 commented 4 years ago

With a new version of Python released, this might be a good opportunity to write some tests or at least considering doing so.

One hot point will be to determine if there has been any discussion of PyInstaller's compatibility with Py 3.8.

this issue is intentionally open-ended

machawk1 commented 4 years ago

Pyinstaller supports Python 3.8 https://github.com/pyinstaller/pyinstaller/issues/4311

machawk1 commented 4 years ago

With Python 3.8.0 on macOS 10.14.6 and 9321ff0412534551c9981ade24c8ccc5d9efb36e

bundledApps/WAIL.py:930: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if serviceId is "wayback":
bundledApps/WAIL.py:933: SyntaxWarning: "is" with a literal. Did you mean "=="?
  elif serviceId is "heritrix":

machawk1 commented 4 years ago

Travis does not appear to support Python 3.8 on macOS just yet per the example at https://docs.travis-ci.com/user/languages/python/ , but does for Windows on Linux -- testing in 411a0b6.

machawk1 commented 4 years ago

461 describes further issues relating to this:

Python 3.8 is not supported by Pyinstaller yet. Attempting to build WAIL using it causes issues on launching the built app.