search

machawk1 / wail

:whale2: Web Archiving Integration Layer: One-Click User Instigated Preservation
https://matkelly.com/wail
MIT License
345 stars 32 forks source link

Version not reported correctly in Windows #466

Closed machawk1 closed 3 years ago

machawk1 commented 4 years ago

Building from latest master e26e87c2eb3fb9095bb8e0272d931d956e9edd73, the version number in About WAIL menu item reports -1, meaning it is never set.

Screen Shot 2020-06-30 at 3 24 11 PM

machawk1 commented 4 years ago

This value is read from an XML file in WAILConfig.py

try:
    with open(infoPlistPath, "r", encoding='latin1') as myfile:
        data = myfile.read()
        vsXML = r"<key>CFBundleShortVersionString</key>\n\t<string>(.*)</string>"
        m = re.search(vsXML, data)
        WAIL_VERSION = m.groups()[0].strip()

...which is macOS-specific. This code was never adapted to Windows. Is this value available programmatically elsewhere?

machawk1 commented 3 years ago

Screen Shot 2020-07-30 at 4 06 27 PM