search

machawk1 / wail

:whale2: Web Archiving Integration Layer: One-Click User Instigated Preservation
https://matkelly.com/wail
MIT License
350 stars 35 forks source link

DMG fails to build #580

Open machawk1 opened 1 month ago

machawk1 commented 1 month ago

As reported by Dhanashree, in building the DMG using the MAKEFILE:

biplist.InvalidPlistException: module 'plistlib' has no attribute 'Data'

It seems the `biplist` library is attempting to access an attribute `Data` in `plistlib`, which has been removed in Python 3.11. I believe this is causing the `InvalidPlistException` error, as `biplist` is trying to read a plist file but is not compatible with the new version of Python.

To address this issue, I am considering the following potential fixes:
1. Update biplist: I will check if there is an updated version of the biplist  library that resolves this compatibility issue with Python 3.11.
2. Modify the code to use plistlib directly: Since recent versions of  plistlib support both binary and XML plist files, I could replace `biplist` with `plistlib` in the affected part of the code.

I verified that the issue persists in Python 3.12.0, macOS 14.6.1, Apple M1, current main branch HEAD 041be9b.

dhanashreedeshmukh commented 2 weeks ago

The plistlib.Data compatibility issue with Python 3.11 has been resolved! I replaced plistlib.Data with bytes in biplist, and it now works smoothly.

machawk1 commented 2 weeks ago

@dhanashreedeshmukh Can you submit a PR to this repo with this fix in place? I can then merge it in and we can close this issue. Thanks!

dhanashreedeshmukh commented 2 weeks ago

I have made the change directly to the biplist library in Python environment (outside of a Git repository)

On Mon, Nov 4, 2024 at 10:05 AM Mat Kelly @.***> wrote:

@dhanashreedeshmukh https://github.com/dhanashreedeshmukh Can you submit a PR to this repo with this fix in place? I can then merge it in and we can close this issue. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/machawk1/wail/issues/580#issuecomment-2454956469, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGLS73IEWYEHYIY3B6LQSTZ655KHAVCNFSM6AAAAABP5EMYKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJUHE2TMNBWHE . You are receiving this because you were mentioned.Message ID: @.***>