machenslab / dPCA

An implementation of demixed Principal Component Analysis (a supervised linear dimensionality reduction technique)
MIT License
279 stars 94 forks source link

Merging components before fitting #34

Closed pkollias closed 3 years ago

pkollias commented 3 years ago

I am wondering if I can use the code to merge effects and fit on the combined marginalization. Similar to what the paper describes describing a marginalization main effect (sensory) and its interaction with time in a single component. I have been trying to use the join parameter but have stumbled on a couple of issues. Also I am not sure if the fact that the _marginalize method calls the parameter generator method with join=False by default