machenslab / dPCA

An implementation of demixed Principal Component Analysis (a supervised linear dimensionality reduction technique)
MIT License
279 stars 94 forks source link

Update setuptools `requires` keyword to `install_requires` #36

Closed charlesbmi closed 2 years ago

charlesbmi commented 2 years ago

When I pip install dpca on Python 3.8, it does not install the dependencies (numexpr, etc.), because the requires keyword has been deprecated and updated to install_requires: https://setuptools.pypa.io/en/latest/references/keywords.html

This PR fixes this and also adds numpy and scipy to the install_requires list.

dkobak commented 2 years ago

Thanks a lot! I am going to go ahead and merge it now. As you can see, this project is not under active development anymore...