search

machinalis / mypy-data

mypy typesheds for the Python data stack
BSD 3-Clause "New" or "Revised" License
86 stars 23 forks source link

Port numpy-mymy upstream into NumPy? #16

Open shoyer opened 7 years ago

shoyer commented 7 years ago

As a NumPy developer and user, I would love to see this happen. I can't promise I'll have the time to make this happen on my own, but I certainly am willing to help anyone with questions about the process.

Step 1 would be to add a license to this repository, preferably 3-clause BSD like NumPy.

dmoisset commented 7 years ago

Hi Stephan, It would be fantastic if this is found to be useful upstream and integrated. Some of the work done here was a bit halted due to some limitations on mypy that may have been fixed in recent releases (I haven't retried yet). Some aspects also can be reimplemented in a better way once the protocol feature (currently in design by the mypy team to be presented as a PEP) is ready (and these changes would be "API-breaking" for people using these), so it might be worth waiting a bit.

Other than that, what do you thing would be needed to push this into numpy upstream?

The repo already has a 3-clause BSD in the master branch.

shoyer commented 7 years ago

Oops, not sure how I missed the license! Yes, that should already cover it.

You raise a good point about making further improvements. So perhaps it is indeed worth waiting a while before integrating these into NumPy proper, at least as anything other than provisional. Protocols will indeed make a big difference for NumPy.

Let me know if you think it would help to move this repository to any of (1) numpy github account, (2) typeshed or (3) numpy proper.

ErikBjare commented 5 years ago

Related issue: https://github.com/machinalis/mypy-data/issues/19

shoyer commented 5 years ago

We’ve started over with stubs in the https://github.com/numpy/numpy-stubs repo