machinamentum / CTR64

N64 emulation research/development for 3DS. Hard fork of CTRX.
67 stars 3 forks source link

Trying to help. #7

Open SNGames-Gaming opened 7 years ago

SNGames-Gaming commented 7 years ago

I don't know if you've seen me on Reddit/3dshacks, but I've been working on picking this up and working on adding the missing rsp core, and optimizing the program for it to work better. However, I want permission from you, machinamentum, so that I can distribute it (of course, you'll be credited as the creator still, since you made all of the code to begin with.) I don't know how to PM on here (I'm new to github) so I'm putting it here. I hope that I can help, and make this emulator a reality, whether it's slow and buggy, or perfect 60fps (doubt it).

So far, I've just looked through the code for any issues, haven't found too many, since it's so bare bones. Adding the rsp core is going to be a chore though.

SNGames-Gaming commented 7 years ago

Also, have you tried looking at Daedalusx64 for RSP emulation? It shouldn't be too hard to port it over.

https://github.com/hulkholden/daedalus/blob/master/Source/Core/RSP_HLE.h https://github.com/hulkholden/daedalus/blob/master/Source/Core/RSP_HLE.cpp

machinamentum commented 7 years ago

Hi, I haven't been reading r/3dshacks for quite some time but I've looked into a few of your threads. The project is under the Beerware license (see: here, you can also read the comment I just made in issue #8 ). It seems a few users have missed the license header (I may have forgotten to put it in some of the files, oops), but the entire project is under Beerware and you may do as you please with the code so long as you keep the Beerware statement in the original files.

Ideally, it'd be cool if you could submit pull requests for any changes you've made, however, I'm only willing to pull in changes so long as the changes are also under Beerware or any other license that virtually submits the new changes into the public domain (or close to). I try to steer clear of looking at other projects' implementations as I'd like to preserve the public domain-ish nature of the project (daedalus is under the GPL, which I've made a few comments on in a few gbatemp threads and partially implied in #8 ). You're free to use CTR64 with GPL'd code, but the changes won't be merged if you decide to submit a pull request for the previous reasons.

Hope this helps!

SNGames-Gaming commented 7 years ago

Ah, okay, thanks so much for the info! I wish you well in the future.

machinamentum commented 7 years ago

No problem, let me know if you have any more questions about the code!