search

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
888 stars 74 forks source link

fix check for binary root ownership #104

Closed codekitchen closed 8 years ago

codekitchen commented 8 years ago

501 is often, but not always, the uid of the user on OS X. For instance in our corp environment, our uid is the same as our active directory id. This new check should be more reliable, as 0 is always the uid of the root user.

zchee commented 8 years ago

@codekitchen Thanks PR!! LGTM. I think it is more correct implementation.

I tested later, and will merge.

zchee commented 8 years ago

@codekitchen Merged. Thanks!!