search

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
888 stars 74 forks source link

Support using the configured UUID instead of always generating a UUID… #133

Closed chirino closed 7 years ago

chirino commented 7 years ago

… so that you can reuse IP addresses for hosts.

zchee commented 7 years ago

@chirino Thanks for the pull request!

It seems LGTM, but now xhyve driver has not configure UUID flag. Maybe this pull request for minikube or minishift? I think better is also add uuid variable flag.

Thanks.

Edit: I means like --xhyve-uuid flag

chirino commented 7 years ago

Yep it's related to minikube/shift see: https://github.com/jimmidyson/minishift/pull/53

zchee commented 7 years ago

@chirino Thanks :) LGTM.

zchee commented 7 years ago

@chirino I'm wait for ci result...

zchee commented 7 years ago

@chirino @jimmidyson merged. Thanks :)

jimmidyson commented 7 years ago

Awesome! Thanks for a great project btw :beers:

zchee commented 7 years ago

@jimmidyson yey \o/

zchee commented 7 years ago

@jimmidyson @dlorenc I think maybe kubenetes team and minikube/minishift like to use release version. I will release the next version after some private works.

jimmidyson commented 7 years ago

We certainly do want to use it! Whenever you get a chance to release that would be great. Thanks!