machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
888 stars 74 forks source link

xhyve/qcow2: support qcow2 disk image format #138

Closed zchee closed 7 years ago

zchee commented 7 years ago

Support QEMU qcow2 disk image format use zchee/go-qcow2.

https://github.com/docker/hyperkit#building

make

GO_BUILD_TAG='lib9p qcow2' make V=1

check

make test-bindings or

zchee commented 7 years ago

/cc @dlorenc @r2d4 Please test it if you have time. If you can't build with any problems, I will upload pre-compile binary.

dlorenc commented 7 years ago

I've been trying to build but running into problems with homebrew/opam. I'll keep trying today.

r2d4 commented 7 years ago
-> ls ~/.minikube/machines/minikube/minikube.qcow2
/Users/mrick/.minikube/machines/minikube/minikube.qcow2

Works with minikube on my machine! 👍

dlorenc commented 7 years ago

Feel free to merge :) @r2d4 tested and it works for him :)

zchee commented 7 years ago

@dlorenc I see :) I will merge it after the fix some issue(go test, travis build).

zchee commented 7 years ago

@r2d4 and, Thanks for test! It might be difficult to build from source because of OCaml dependency, so I will release pre-build binary as soon as possible.