search

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
888 stars 74 forks source link

Defer the unmount. #143

Closed dlorenc closed 7 years ago

dlorenc commented 7 years ago

I had a couple cases where an error happened on line 608, then the iso never got unmounted so I couldn't properly delete the .minikube directory.

zchee commented 7 years ago

@dlorenc LGTM. I also have the same problem.

zchee commented 7 years ago

@dlorenc Just in case, it's ready to merge? The merge process are

143 -> #144

OK?

dlorenc commented 7 years ago

Yup, I can rebase 144 after this goes in. I made them as separate branches that are derived from each other, not sure how github will handle this.

zchee commented 7 years ago

@dlorenc Okay, I'll merge it. please rebase if necessary.

zchee commented 7 years ago

@dlorenc Ah, this is PR for zchee:minikube-iso_kexec? I'm misunderstood. ok, got it.