search

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
888 stars 74 forks source link

Auto-detect whether the kernel is bzImage or vmlinuz. #144

Closed dlorenc closed 7 years ago

dlorenc commented 7 years ago

This changes the extract function to just copy everything it can find, and it moves the detection into the getXhyveArgs function.

What do you think of this approach?

Ref #140

zchee commented 7 years ago

@dlorenc Sorry for delay. I'll check it later. Thanks!

dlorenc commented 7 years ago

I'll check it later. Thanks!

Thanks, let me know what you think of the approach. Minikube itself won't really know what's in the iso either, so passing this in via a struct parameter would be hard.

zchee commented 7 years ago

As in https://github.com/zchee/docker-machine-driver-xhyve/pull/140#issuecomment-257002015

However, this problem might be solved with adding initialize method. Sorry, I still don't understand minikube internal. Where do I should add the initialize method for having a backward compatibility of minikube?

I wanted to say "backward compatibility method" is this approach. And would be able to provide backward compatibility without changing the minikube.

Hardcoded "kernel image" filename is a little bit not good. But It is inevitable. So almost LGTM.

zchee commented 7 years ago

@dlorenc Sorry, conflicting xhyve/xhyve.go. and WDYT vmlinuz and vmlinux? Please rebase.

zchee commented 7 years ago

LTGM. waiting for CI.