search

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
888 stars 74 forks source link

Fix #150 Extract kernel options from the syslinux.conf file if exist #152

Closed praveenkumar closed 7 years ago

praveenkumar commented 7 years ago

@zchee please do a review. I tested with boot2docker, minikube and centos all works as expected. I am still a golang newbie so code might be not so appealing but happy to improve as per suggestion.

Also tested with ubuntu and get error message as expected.

(ubuntu) DBG | Extracting Kernel Options
Error creating machine: Error in driver during machine creation: Not abled to parse isolinux.cfg, Please use --xhyve-boot-cmd option
zchee commented 7 years ago

@praveenkumar Thanks! I'll review it :)

zchee commented 7 years ago

sorry for the delays. I'll review at today.

zchee commented 7 years ago

@praveenkumar Ah, forgot @ mention. This comment just for mentioned.

zchee commented 7 years ago

@praveenkumar And, nit: comment is not negative. Just wondering(?) No offense to you.

praveenkumar commented 7 years ago

@zchee Thanks for detailed review, I will incorporate those suggestion and update the PR soon.

zchee commented 7 years ago

@praveenkumar Thanks :)

zchee commented 7 years ago

@praveenkumar thanks for update :) ready?

praveenkumar commented 7 years ago

@zchee yes, let's merge it :)

zchee commented 7 years ago

@praveenkumar I see :) I'll merge it after the final check, Thanks!!

praveenkumar commented 7 years ago

I'll merge it after the final check.

Sure, take your time 👍

zchee commented 7 years ago

@praveenkumar Thanks :) I tested it, works successfully! LGTM, merge.