Don't hardcode the docker user id

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)

https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve

BSD 3-Clause "New" or "Revised" License

888 stars 74 forks source link

Don't hardcode the docker user id #171

Closed dalehamel closed 7 years ago

dalehamel commented 7 years ago

The docker user ID is currently hardcoded to 1000, which is causing issues: https://github.com/kubernetes/minikube/issues/1374

I believe this is because there is a race condition in which user is created first (docker or rkt).

We may want to make this take an option for which username (docker or rkt) but I think that it would be expected by most uses for these files to be owned by the docker user, since that is the user they'll be logging in as.

FYI @zchee

zchee commented 7 years ago

@dalehamel LGTM, thanks and understand that issue.

/cc @dlorenc @r2d4

zchee commented 7 years ago

@dalehamel Merged. thanks!!