search

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
888 stars 74 forks source link

Ignore setupmounts #174

Closed r2d4 closed 7 years ago

r2d4 commented 7 years ago

The 9p mount already exists in this case. This is reverting back to a similar behavior before https://github.com/zchee/docker-machine-driver-xhyve/pull/161/files

This now logs a warning, but this is a not fatal error on a recreate. I'm not sure there's a cleaner way since Start() has no context of if it is called on new VM or a recently stopped VM.

Reference: https://github.com/kubernetes/minikube/issues/1400#issuecomment-298503774

zchee commented 7 years ago

@r2d4 LGTM. thanks.