Fix #179 add process name check to getState

[gbraad]

This fixes #179 by checking the executable name of the process retrieved.

[zchee]

@gbraad Thanks pull request. Now I test that fix. Please wait a while.

[praveenkumar]

@gbraad Thanks, will also test this out and provide feedback.

[zchee]

/cc @dlorenc @r2d4

[zchee]

@gbraad Also, could you add static vendoring github.com/mitchellh/go-ps? We use gvt(for now. Maybe I will switch to dep), so:

go get -u -v -x github.com/FiloSottile/gvt
gvt fetch github.com/mitchellh/go-ps
git add vendor/manifest vendor/github.com/mitchellh

[zchee]

@gbraad And CI are failed. but nevermind. it's caused by OCaml third-party install.

[praveenkumar]

We use gvt(for now. Maybe I will switch to dep)

@zchee what if we can switch to glide. we are using it for minishift quite a long time and works as expected. I can help you with migration to glide.

[zchee]

@praveenkumar Hm, but glide author?(sdboyer) now maintain golang/dep. And dep command already have glide importer. But yeah, I think dep is experimental, glide is production ready. If you really like glide, It’s up to you. switch to glide pull request is welcome.

[praveenkumar]

Tested out this patch and it does work as described only need to put https://github.com/zchee/docker-machine-driver-xhyve/pull/180#issuecomment-311587314 so make build doesn't fail.

[gbraad]

Thanks @zchee, will do this ASAP

[zchee]

@gbraad Thanks. I'll release the new version after check and merge this pull request. FYI, I tested minikube side, it seems works successfully.

[gbraad]

so basically you are checking in a fixed version of the library as part of the repositry, under vendor

[gbraad]

rebased and tested with minikube and minishift. all OK.

[gbraad]

inverted if statement to return errors first.

[zchee]

@gbraad Thanks! I'll check and merge it. No reply from Google side, but seems to no problem this change.

[gbraad]

they are both (@dlorenc, @r2d4) in a far away timezone. it is likely they will see it in about a few hours. But I always test against minikube as we are trying to align with them more. But n their case it is not the default hypervisor.

[zchee]

@gbraad I see. Yes, I also check minikube some commands. So already double checked. I'll merge it. Thanks for contribution.

[gbraad]

maybe have some other changes over time, as the PID code should also check for dead/stale PID files. But this is a first improvement!

[dlorenc]

Looks great to me, thanks!

[r2d4]

LGTM 👍