machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)

https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve

BSD 3-Clause "New" or "Revised" License

888 stars 73 forks source link

Switch from using hdiutil to parsing the iso file directly. #183

Open dlorenc opened 7 years ago

dlorenc commented 7 years ago

I'm still not completely happy with this code, but I wanted to send it out early and see what you thought @zchee.

zchee commented 7 years ago

@dlorenc Thanks. I know iso9660 package (but was not digging), it's make sense. Some users waiting to release the new version and pre-build binary. I'll check that package and test this pull request after the release new version. https://github.com/zchee/docker-machine-driver-xhyve/pull/182

zchee commented 7 years ago

@dlorenc

I'm still not completely happy with this code

OK, I'll wait for the complete code. Could you rebase to master(for now)? Maybe CI test is successful.

zchee commented 7 years ago

and, /cc @praveenkumar because he wrote the related code.

praveenkumar commented 7 years ago

Thanks for notification, I will go through it and test.

praveenkumar commented 7 years ago

Tested this PR with CentOS/b2d iso and it able to extract kernel options as expected. 👍

zchee commented 7 years ago

@dlorenc This PR and #189, Which is a priority?

dlorenc commented 7 years ago

189, I'll rebase this one after :)