search

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
889 stars 73 forks source link

Add glide tool as go dependency management #186

Closed praveenkumar closed 7 years ago

praveenkumar commented 7 years ago

This will add glide as dependency management tool which will make easy to have 3rd party modules part of this repo. I also added step in README file. Give it a try.

praveenkumar commented 7 years ago

cc @zchee @dlorenc @r2d4

zchee commented 7 years ago

@praveenkumar I have short tested this pull request. LGTM. In particular, included jceel/lib9p is great :) I'll more testing.

zchee commented 7 years ago

@praveenkumar Ah, vendor/lib9p submodule is duplicate. Could you try below? (But sorry, I do not know this is the correct way to delete git submodule)

git submodule deinit vendor/lib9p
git rm --cached vendor/lib9p
git rm .gitmodule
git add .gitmodule vendor/lib9p
.
.
praveenkumar commented 7 years ago

@zchee will check and let you know.

praveenkumar commented 7 years ago

@zchee removed lib9p submodule now.

zchee commented 7 years ago

@praveenkumar I'll check it. Thanks.

zchee commented 7 years ago

@praveenkumar LGTM. Thanks :D