search

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
889 stars 73 forks source link

Update 'xcrun clang' usage for XCode 10 #212

Closed rmoats closed 1 year ago

rmoats commented 5 years ago

In Mojave / XCode 10 environment, C-based dependencies fail to build due to strictness of 'clang' (can't find 'stdlib.h'). The 'xcrun -f clang' does not search OS X include directories by default like the '/usr/bin/clang' does. The solution is to add the '--sdk macosx' to the 'xcrun' call. Also my change calls 'xcrun' every time to run clang—the executable lookup is cached by 'xcrun' so this is not slow.

praveenkumar commented 5 years ago

@rmoats Can you also take a look to travis failure when have some time?

rmoats commented 5 years ago

The build errors are from dependency issues with the latest brew ocaml components. I'll see what can be done.

praveenkumar commented 5 years ago

@rmoats Thanks, did you get sometime to look into this error?

praveenkumar commented 5 years ago

ping @rmoats

rmoats commented 5 years ago

Sorry, I’ve been out of town for a bit—I tried pinning the version of an ocaml dependency to what it used to be, but a Travis CI build showed different ocaml-related errors so I will need to go further...