search

machine-drivers / docker-machine-driver-xhyve

docker-machine/minikube/minishift driver plugin for xhyve/hyperkit (native macOS hypervisor.framework)
https://godoc.org/github.com/machine-drivers/docker-machine-driver-xhyve
BSD 3-Clause "New" or "Revised" License
889 stars 73 forks source link

Use xhyve to get the mac address #38

Closed johanneswuerbach closed 8 years ago

johanneswuerbach commented 8 years ago

https://github.com/mist64/xhyve/pull/79 allows to fetch the mac address using xhyve instead of using vmnet directly

zchee commented 8 years ago

@johanneswuerbach Thanks!!

but, If remove vmnet/*, We will not be able to test in travis for xhyve can not start. See https://github.com/zchee/docker-machine-driver-xhyve/pull/37 and https://travis-ci.org/zchee/docker-machine-driver-xhyve/jobs/99313858

How do you think?

zchee commented 8 years ago

@johanneswuerbach Or, we do not need to be test uuid and mac ?

johanneswuerbach commented 8 years ago

While more coverage is great, I personally would prefer to merge this PR in this case and not to test uuid and mac for now. Copying at lot of xhyve src to be able to test feels worse and might also break in the future. After this PR this driver would still work when xhyve decides to change their UUID2Mac implementation.

WDYT?

zchee commented 8 years ago

@johanneswuerbach OK, I understand. LGTM.

johanneswuerbach commented 8 years ago

I like the way virtualbox is unit tested in docker/machine, maybe something worth adapting for xhyve https://github.com/docker/machine/blob/master/drivers/virtualbox/virtualbox_test.go

zchee commented 8 years ago

@johanneswuerbach Thanks. I will use that as reference from now on.