search

machine-drivers / machine

Machine management for a container-centric world
Apache License 2.0
25 stars 16 forks source link

Fix missing Virtual Switch in Config with Hyper-V #25

Closed blueelvis closed 4 years ago

blueelvis commented 4 years ago

Description

This Pull request sets the VSwitch at the driver level after getting the best available switch from chooseVirtualSwitch().

Related issue(s)

This Pull Request fixes the issue mentioned over here - https://github.com/kubernetes/minikube/issues/5672

blueelvis commented 4 years ago

/cc: @tstromberg @afbjorklund

blueelvis commented 4 years ago

Could someone please review this PR once free? Thanks!

gbraad commented 4 years ago

You addressed the wrong poeple to review the PR\

(Thomas is very busy with general Minikube issues, which is like Anders, very focussed on non-Windows platforms)

gbraad commented 4 years ago

Want to run a test ... so merging this later.

blueelvis commented 4 years ago

@gbraad - Thanks for the approval! I didn't know that you would be reviewing the PRs (I didn't see anyone I know in the MAINTAINERS file).

gbraad commented 4 years ago

We didn't modify these, but we might want to. Good point.

blueelvis commented 4 years ago

@gbraad - Could you please merge this PR? I don't have the permissions to merge it after your approval.