Fix Powershell in CMD being mis-detected

machine-drivers / machine

Machine management for a container-centric world

Apache License 2.0

25 stars 16 forks source link

Fix Powershell in CMD being mis-detected #34

Closed spowelljr closed 3 years ago

spowelljr commented 3 years ago

Description

If you spawn a Powershell instance from CMD, sometimes the SHELL environment variable still points to CMD in the Powershell instance. So if SHELL is pointing to CMD, let's do extra work to get the correct shell.

afbjorklund commented 3 years ago

@spowelljr : This would need an upstream issue and PR as well, at https://github.com/docker/machine

Sounds good to me, I'm not sure how many start new CMD shells from their Powershell - but if they do...

spowelljr commented 3 years ago

@afbjorklund Thanks for merging, I'll make an upstream issue and PR as well.

afbjorklund commented 3 years ago

Not holding my breath that anyone will ever look at it, but just in case...

spowelljr commented 3 years ago

Upstream issue https://github.com/docker/machine/issues/4891 & PR https://github.com/docker/machine/pull/4892