Open Tomcli opened 2 years ago
/assign @drewbutlerbb4
to reproduce, pick one of the model yaml and change the link to an invalid link.
Thanks @Tomcli -- this is a good hole to plug, especially when URL go out of date.
I added an issue to help keep URL working: https://github.com/machine-learning-exchange/katalog/issues/43
However, we also need to give the user who uploaded the YAML some feedback on an invalid readme_url
to not let a typo in the URL get unnoticed
This issue was commented on by @Tomcli on PR #228
One of the use cases we want to cover here is when the
readme_url
is not valid. We want to have some fall back logic if one of those README links returns a404
error.
Alternative ways to address this issue:
readme_url
-- This is not perfect since that URL may no longer be available after some timereadme_url
s are valid (machine-learning-exchange/katalog#43)To piggyback off of @ckadner's comment, I will add some notes for this issue.
- In the UI, every time an assets details are loaded, check for a 404 and fall back to the old description tab before loading and rendering the Readme tab
The UI can independently query the markdown file url and if a failing status is returned then the UI can fallback on the old asset detail tab. In this case the following will be needed:
Describe the bug When the yaml readme url doesn't exist or pointing to the wrong link, it shows the below error
We need to render the old description if the README link is not valid.