machine-shop / mothra

Automated butterfly wing length measurement
Other
27 stars 15 forks source link

Adding `--auto_rotate` argument #100

Closed alexdesiqueira closed 2 years ago

alexdesiqueira commented 2 years ago

Mothra automatically tilting images could be cumbersome, mainly when EXIF data is not correct. Here, we:

codecov-commenter commented 2 years ago

Codecov Report

Merging #100 (2d70344) into main (141af3c) will decrease coverage by 10.08%. The diff coverage is 77.27%.

@@             Coverage Diff             @@
##             main     #100       +/-   ##
===========================================
- Coverage   81.24%   71.15%   -10.09%     
===========================================
  Files          17       10        -7     
  Lines         725      468      -257     
===========================================
- Hits          589      333      -256     
+ Misses        136      135        -1     
Impacted Files Coverage Δ
mothra/misc.py 62.31% <ø> (+0.59%) :arrow_up:
mothra/preprocessing.py 76.19% <76.19%> (ø)
mothra/tracing.py 63.09% <100.00%> (ø)
mothra/tests/test_misc.py
mothra/tests/test_plotting.py
mothra/tests/test_pipeline.py
mothra/tests/test_binarization.py
mothra/tests/test_tracing.py
mothra/tests/test_measurement.py
mothra/tests/test_ruler_detection.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 141af3c...2d70344. Read the comment docs.

alexdesiqueira commented 2 years ago

@stefanv on the slow processing for test_pipeline.py: it seems that it tries to run the pipeline in all images within the test folder. We need some images more to test different conditions, now; I think they should all live at the same folder. Maybe we could set only one image to test_pipeline instead.