Fix ruler detection, add detailed plots

machine-shop / mothra

Automated butterfly wing length measurement

Other

27 stars 15 forks source link

Fix ruler detection, add detailed plots #36

Closed theobdt closed 5 years ago

theobdt commented 5 years ago

removes magic numbers left for getting ruler signal, which would cause issues
add new plotting option: '-pp' or '--detailed_plot' to help debugging. Additional plots: ruler signal, fourier transform of ruler signal and tags edges.
fixes broken pipeline when filename was given as input
updates tests

theobdt commented 5 years ago

The issue with BMNHE_1059027 was that is was of a different resolution, and there were some magic numbers left, which would misplace the area where the ruler signal is extracted (red rectangle). Here you can see attached the detailed plots before and after fix : Before fix: BMNHE_1059027_before_fix

After fix: BMNHE_1059027_after_fix

stefanv commented 5 years ago

I'm going to merge this for now in the interest of moving things forward, but I think the axes arguments should be made optional (if this ends up being used as a library, constructing those would be extraneous).