Need integration with AppVeyor CI

[bsommardahl]

I've used TC's integration in the past and being able to read test results in TeamCity has been great. Now, I'm using AppVeyor CI and need something similar. I'm willing to contribute this, but thought it would be a good idea to start a conversation about it here first.

[bsommardahl]

I think I need to modify two and create two classes:

• = Machine.Specifications.ConsoleRunner/Program.cs (around this line)
• = Machine.Specifications.ConsoleRunner / Options.cs (around this line and this line)
• + AppVeyorReporter (patterned after TeamCityReporter)
• + AppVeyorServiceMessageWriter (patterned after TeamCityServiceMessageWriter)

[FeodorFitsner]

This is how it's made for xUnit: https://github.com/xunit/xunit/pull/117

[bsommardahl]

Thanks @FeodorFitsner

[bsommardahl]

AppVeyor CI has an API that receives information about tests so that they will appear in the build results. I plan on creating a new reporter patterned after @FeodorFitsner's visitor in the pull request for xUnit he mentioned above. It uses an http web client to send messages to AppVeyor CI at different stages of the test lifecycle.

[bsommardahl]

@agross I'm writing a listener for AppVeyor similar to the TeamCityReporter listener. I have a question. Does the listener need to worry about normal console output (test results, etc)? If not, I'm done.

[danielmarbach]

Go ahead. Just make sure that everything is speced out properly ;) Awesome feature!

[bsommardahl]

@danielmarbach I'm noticing a lot of inconsistency in spacing and style. How can I make sure I'm formatting things like you guys want it?

[danielmarbach]

That is still a task in the issue tracker. Go for normal indentation (4 spaces) and if possible stylecop complaint (except documentation rules)

[agross]

@bsommardahl In TeamCity interleaved output with service messages and test output is not an issue. I don't know about AppVeyor, though.

[bsommardahl]

I added some basic console feedback just to show progress. One of the cool things about AppVeyor is that the console output is a first class citizen and is front-and-center. So some form of console output is important, even if the test results are also going to the AppVeyor API.

[danielmarbach]

I’ll review it next weekend ok? Bevor I have no time because I go with my company to an education camp

Daniel On 21 Jun 2014, at 00:40, Byron Sommardahl notifications@github.com wrote:

I added some basic console feedback just to show progress. One of the cool things about AppVeyor is that the console output is a first class citizen and is front-and-center. So some form of console output is important, even if the test results are also going to the AppVeyor API.

— Reply to this email directly or view it on GitHub.

[holytshirt]

Thanks @bsommardahl and @danielmarbach I've just started using appveyor, thanks for doing the patch!

[danielmarbach]

@holytshirt @bsommardahl can you guys please try out http://www.nuget.org/packages/Machine.Specifications/0.8.3-Beta0000-0007 and give feedback. When everything works I will release 0.8.3

[danielmarbach]

Any updates @holytshirt @bsommardahl ?

[FeodorFitsner]

I guess Byron is working on these items: http://help.appveyor.com/discussions/questions/332-is-mspec-supported#comment_33585591

[FeodorFitsner]

@bsommardahl Do you need a help with fixing these stuff?

Moving notes from AppVeyor forums:

• Getting wrong test duration (second screenshot) because -1 is getting passed into AppVeyor (relevant code line).
• It makes sense to prefix test name with context name to have, in my case:

when transferring between two accounts - should debit the from account by the amount transferred
when transferring between two accounts - should credit the to account by the amount transferred
when transferring an amount larger than the balance of the from account - should not allow the transfer

• While encoding payload to JSON double quotes in value should be escaped (relevant code line)

[danielmarbach]

@FeodorFitsner @bsommardahl make sure you PR the changes against hotfix-0.8.3 branch. When do think we can pull this in? I want to release Resharper Gallery support along the line with the version bump

[FeodorFitsner]

@danielmarbach I think I can pickup from here and fix the issue above. What's your deadline?

[danielmarbach]

@FeodorFitsner I don't really have a hard deadline. I thought you guys want it asap that's why I decided to do a release before 0.9.0. I'm still having large issues regarding the resharper integration on the development branch (0.9.0). I think I can start investigating again in the resharper area next week. But having 0.8.3 ready at the end of next week would be awesome.

[FeodorFitsner]

OK, I see. So, I will have to do a pull request to "master" and base it on "hotfix-0.8.3", right?

[danielmarbach]

Do the pull against hotfix, thanks

Am 04.07.2014 um 13:09 schrieb Feodor Fitsner notifications@github.com:

OK, I see. So, I will have to do a pull request to "master" and base it on "hotfix-0.8.3", right?

— Reply to this email directly or view it on GitHub.

[bsommardahl]

Hey guys. I have had a packed week and I'm traveling to the states tomorrow, so not much hope of me getting this worked on until next week. :( If anyone is in a hurry to get this moving, feel free to continue my work. Otherwise, I'll be taking a look at this next week. Sorry for the delay, but I wanted to at least give an update.

[danielmarbach]

No worries! I know how this feels. I just wanted to show my attention zo the project/contributions because I have been quiet lately too. We get this done together :)

Am 05.07.2014 um 01:44 schrieb Byron Sommardahl notifications@github.com:

Hey guys. I have had a packed week and I'm traveling to the states tomorrow, so not much hope of me getting this worked on until next week. :( If anyone is in a hurry to get this moving, feel free to continue my work. Otherwise, I'll be taking a look at this next week. Sorry for the delay, but I wanted to at least give an update.

— Reply to this email directly or view it on GitHub.

[FeodorFitsner]

Have a safe trip and easy recovery from jet-lag :) I will start doing those items (besides, they are minor) and if I have any questions I'll ask you guys for advice.

[danielmarbach]

PR merged. You can grab the latest 0.8.3-Beta build on nuget. As soon as I have positive feedback about it I will release it

[FeodorFitsner]

Thank you! Will test it and let you know about results.

[FeodorFitsner]

Verified - AppVeyor integration in the latest 0.8.3-beta works well.

[danielmarbach]

Just released as part of 0.8.3