machine / machine.specifications

Machine.Specifications is a Context/Specification framework for .NET that removes language noise and simplifies tests.
MIT License
885 stars 178 forks source link

Performance: Establish/Cleanup are being called for every "It" (in Visual Studio IDE) #325

Closed ivanz closed 5 years ago

ivanz commented 7 years ago

Migrated from vstest adapter repo

IDEs and e.g. VS adapter allow to run a single test ("It"), but since MSpec core doesn't support that currently adapters are running the whole spec (class).

Note: need to watch out when implementing this so that Behavior's It are supported properly.

einari commented 7 years ago

The core supports running specific members - for the old dotnet testrunner - I implemented its usage here

ivanz commented 7 years ago

Good point. I was mechanically copy pasting/moving issues from the machine vstest adapter repo to here to centralize issue management.

eskitek commented 7 years ago

@einari , since the mspec core now supports running specific members as you mentioned, does that mean that this issue is fixed? Or does additional work still need to be done to make machine.vstestadapter run Establish/Cleanup once per spec instead of once per "It"?

robertcoltheart commented 5 years ago

This should be fixed with https://github.com/machine/machine.vstestadapter/pull/87