search

machineagency / science-jubilee

Controlling Jubilees for Science!
https://science-jubilee.readthedocs.io/
MIT License
24 stars 10 forks source link

picamera required dependeny #38

Open brendenpelkie opened 11 months ago

brendenpelkie commented 11 months ago

The picamera package is listed as a dependency in setup.py, making science_jubilee uninstallable on a non-pi system (or at least my WSL ubuntu instance).

Proposed fix:

  1. remove picamera from base install dependencies
  2. add steps to check install/manage install of picamera to camera tools that directly run on a pi
bsubbaraman commented 11 months ago

Good catch-- currently it installs fine on mac or windows, but the conditional check in setup.py is currently if running on linux; I would propose changing this to check the os_name to only install on Raspberry Pi!

brendenpelkie commented 11 months ago

That makes sense too. That's cool I didn't know you could do conditional installs like that!

brendenpelkie commented 11 months ago

Addressed by #41. Checks for pi camera by checking for aarch64 machine instead of linux platform.

bsubbaraman commented 8 months ago

Reopening because I just tried a fresh install on my pi 3 which isn't aarch64 so picamera doesn't install! I'll submit a pull request with a fix for this one