machinebox / graphql

Simple low-level GraphQL HTTP client for Go
https://blog.machinebox.io/a-graphql-client-library-for-go-5bffd0455878
Apache License 2.0
933 stars 218 forks source link

Add retry policy for graqhql client #18

Closed dduyVeritone closed 5 years ago

dduyVeritone commented 6 years ago

Background

Often times, we need to retry graphql request in case of transient network issue. This change aims to add that retry capabilities if the library consumers want to.

Overview

Test

matryer commented 6 years ago

This is an excellent PR. Unfortunately, it feels to me like the wrong place to add this functionality. I always like backoff/retry functionality to live outside the client code. I could be convinced otherwise, perhaps we can get some other views? Have you seen this backoff package?

dahernan commented 5 years ago

closing for now