machinebox / graphql

Simple low-level GraphQL HTTP client for Go

https://blog.machinebox.io/a-graphql-client-library-for-go-5bffd0455878

Apache License 2.0

933 stars 218 forks source link

8 - Provide clearer error for non-200 status codes without JSON #19

Closed erutherford closed 5 years ago

erutherford commented 6 years ago

What

This adds a check for a non-200 status code if there's a failure to unmarshal the response from the server.
Added tests to confirm the current behavior of returning the first error in the index if it is able to parse the response.

machinebox#8

erutherford commented 6 years ago

@dahernan is it possible you'd be able to take a look at this? I'm definitely open to suggestions on the PR, I was trying to maintain the current behavior, but account for errors where there isn't a JSON response with as little modification as possible.

dahernan commented 6 years ago

Sorry I have no context for this, maybe @matryer could help

matryer commented 6 years ago

Yeah, I’ll look at this tomorrow morning.

Mat

On 11 Sep 2018, at 20:08, David Hernandez notifications@github.com wrote:

Sorry I have no context for this, maybe @matryer could help

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

erutherford commented 6 years ago

I went based of the last couple merges, sorry for the incorrect ping. Thanks for checking out the PR and providing this client.

erutherford commented 5 years ago

Looks like it's failing because of this, updating my branch. https://github.com/golang/lint/issues/415

matryer commented 5 years ago

Thanks @erutherford, nice work.