machinebox / issues

Machine Box issues, bugs and feature requests
2 stars 0 forks source link

facebox: /facebox/similar returns wrong `facesCount` #3

Closed cgarciaarano closed 7 years ago

cgarciaarano commented 7 years ago

facebox v1 (0cabe3d)

When getting results for /facebox/similar endpoint, the facesCount is not returning the number of faces found (0 instead of 3 in this example).

This is the response:

{
        "success": true,
        "facesCount": 0,
        "similar": [
                {
                        "id": "59439e09fac4721f4afa9856b13f6dba",
                        "name": "Kilian Jornet"
                },
                {
                        "id": "59439e2435c028f07d25e72d7076d288",
                        "name": "Kilian Jornet"
                },
                {
                        "id": "59439b19dce6c68bc0593ce42a31b630",
                        "name": "Carlos Garcia"
                }
        ]
}

PD: I really look like Kilian Jornet 😄

dahernan commented 7 years ago

Hi Kilian or Carlos :D

I've just fixed the endpoint and pushed to docker hub, please try to a docker pull, and let me know if the last image fixed the problem.

Thanks

cgarciaarano commented 7 years ago

Fixed, thanks!

{
        "success": true,
        "facesCount": 3,
        "similar": [
                {
                        "id": "59439e09fac4721f4afa9856b13f6dba",
                        "name": "Kilian Jornet"
                },
                {
                        "id": "59439e2435c028f07d25e72d7076d288",
                        "name": "Kilian Jornet"
                },
                {
                        "id": "59439b19dce6c68bc0593ce42a31b630",
                        "name": "Carlos Garcia"
                }
        ]
}

BTW, awesome work and talk at Docker Madrid!

dahernan commented 7 years ago

Great!, let me know what are you building via twitter or email, I'd like to know more use cases