machinebox / issues

Machine Box issues, bugs and feature requests
2 stars 0 forks source link

classificationbox: create model response docs are slightly wrong #33

Closed joshrotenberg closed 5 years ago

joshrotenberg commented 6 years ago

classificationbox v0 (7178dcd)

I'm not getting the classes back in the response when I create a model, and I do get predict_only: false which isn't mentioned until later in the docs (in state uploading):

Here is the full request/response.

--> POST http://localhost:8080/classificationbox/models
Content-Type: application/json; charset=utf-8
Content-Length: 119
Accept: application/json; charset=utf-8

{"id":"sentiment1","name":"sentimentModel","options":{"skipgrams":1,"ngrams":1},"classes":["class1","class2","class3"]}
--> END POST (119-byte body)
<-- 200 OK http://localhost:8080/classificationbox/models (1061ms)
Content-Type: application/json; charset=utf-8
Vary: Origin
X-Machinebox-Build: 7178dcd
X-Machinebox-Name: classificationbox
X-Machinebox-Version: 0
Date: Wed, 12 Sep 2018 19:05:46 GMT
Content-Length: 142

{
    "success": true,
    "id": "sentiment1",
    "name": "sentimentModel",
    "options": {
        "ngrams": 1,
        "skipgrams": 1
    },
    "predict_only": false
}
<-- END HTTP (142-byte body)
dahernan commented 5 years ago

should be fixed if you pull last image