search

machinekit / QtQuickVcp

A Virtual Control Panel for Machinekit written in Qt/C++/QML
Other
128 stars 74 forks source link

ConnectionWindow: use list property again #275

Closed machinekoder closed 5 years ago

machinekoder commented 6 years ago

Turns out we need the list property, else the default property does not work.

ArcEye commented 6 years ago

Didn't get a reply last time.

"Can we drop whatever says that merging is blocked until a positive review is entered? Can't see anything in github itself, so assume it is in Appveyour or Travis"

luminize commented 6 years ago

On 9 Jul 2018, at 18:54, ArcEye notifications@github.com wrote:

Didn't get a reply last time.

"Can we drop whatever says that merging is blocked until a positive review is entered?

I would like that too. It's pretty annoying. Can't see anything in github itself, so assume it is in Appveyour or Travis"

cdsteinkuehler commented 6 years ago

On 7/9/2018 4:21 PM, Bas de Bruijn wrote:

On 9 Jul 2018, at 18:54, ArcEye notifications@github.com wrote:

Didn't get a reply last time.

"Can we drop whatever says that merging is blocked until a positive review is entered?

I would like that too. It's pretty annoying. Can't see anything in github itself, so assume it is in Appveyour or Travis"

It's a github feature, found under "Settings -> Branches -> Branch Protection Rules:

https://help.github.com/articles/enabling-required-reviews-for-pull-requests/

I've turned it off for master (the only branch with any protection rules in place). It might need to be disabled for some of the other repos as well.

-- Charles Steinkuehler charles@steinkuehler.net

ArcEye commented 5 years ago

Thanks @cdsteinkuehler

luminize commented 5 years ago

Great, Thanks @cdsteinkuehler