GLPathItem: Remove tool offset from calculation

machinekit / QtQuickVcp

A Virtual Control Panel for Machinekit written in Qt/C++/QML

Other

128 stars 74 forks source link

GLPathItem: Remove tool offset from calculation #297

Open gb-g opened 3 years ago

gb-g commented 3 years ago

Paths that have a tool offset are displayed wrong. This PR displays them the same way as in AXIS. Tested on LInux, on a lathe, with tool offset: Path display as in AXIS, and the tool offset is still used by the lathe machine itself.

cerna commented 3 years ago

This pull request is in draft status intentionally and not by accident, right?

gb-g commented 3 years ago

Yes. Feedback is welcome, though!

machinekoder commented 3 years ago

Interesting, if it works, this looks good. However, it indicates that the reported machine position is not absolute. Since this is the preview module only, I think it is okay, just worth mentioning.